Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message parser being slow to process very long messages with too many symbols #33256

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 11, 2024

Backport of #33227

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: c37ce06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/message-parser Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Sep 11, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.42%. Comparing base (0e7faec) to head (c37ce06).
Report is 2 commits behind head on release-6.10.6.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.6   #33256      +/-   ##
==================================================
+ Coverage           56.64%   59.42%   +2.77%     
==================================================
  Files                2505     2504       -1     
  Lines               55683    55706      +23     
  Branches            11518    11529      +11     
==================================================
+ Hits                31544    33101    +1557     
+ Misses              21476    20835     -641     
+ Partials             2663     1770     -893     
Flag Coverage Δ
e2e 60.95% <ø> (+4.41%) ⬆️
unit 73.90% <ø> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-cfa julio-cfa added stat: ready to merge PR tested and approved waiting for merge stat: QA tested labels Sep 11, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA tested labels Sep 11, 2024
@julio-cfa julio-cfa added stat: ready to merge PR tested and approved waiting for merge stat: QA tested and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Sep 11, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Sep 11, 2024
@julio-cfa julio-cfa added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2024
@kodiakhq kodiakhq bot merged commit a45b88c into release-6.10.6 Sep 11, 2024
67 of 68 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.10.6-33227 branch September 11, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants