Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message parser being slow to process very long messages with too many symbols #33258

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 11, 2024

Backport of #33227

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: a302d5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/message-parser Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Sep 11, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.47%. Comparing base (0163dd5) to head (a302d5b).
Report is 2 commits behind head on release-6.8.7.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.8.7   #33258      +/-   ##
=================================================
+ Coverage          55.05%   58.47%   +3.41%     
=================================================
  Files               2318     2377      +59     
  Lines              51148    52131     +983     
  Branches           10392    10667     +275     
=================================================
+ Hits               28160    30483    +2323     
+ Misses             20542    19986     -556     
+ Partials            2446     1662     -784     
Flag Coverage Δ
e2e 59.32% <ø> (+5.53%) ⬆️
unit 78.43% <ø> (+2.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-cfa julio-cfa added stat: ready to merge PR tested and approved waiting for merge stat: QA tested labels Sep 11, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA tested labels Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 9a68735 into release-6.8.7 Sep 11, 2024
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.8.7-33227 branch September 11, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants