Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Federation callback not awaiting model call #33298

Merged
merged 3 commits into from
Sep 16, 2024
Merged

fix: Federation callback not awaiting model call #33298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a721b31
fix federation callback not awaiting model call
KevLehman Sep 16, 2024
6067d8a
Create great-humans-live.md
KevLehman Sep 16, 2024
803f45b
Merge branch 'develop' into fix/federation-callback-await
kodiakhq[bot] Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-humans-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixed a Federation callback not awaiting db call
2 changes: 1 addition & 1 deletion apps/meteor/app/federation/server/hooks/afterUnsetReaction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getFederationDomain } from '../lib/getFederationDomain';
import { clientLogger } from '../lib/logger';

async function afterUnsetReaction(message, { user, reaction }) {
const room = Rooms.findOneById(message.rid, { fields: { federation: 1 } });
const room = await Rooms.findOneById(message.rid, { projection: { federation: 1 } });

// If there are not federated users on this room, ignore it
if (!hasExternalDomain(room)) {
Expand Down
Loading