Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition when forwarding livechat by splitting subscription removal #33389

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 27, 2024

Backport of #33381

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner September 27, 2024 17:47
Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: ea07b1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Sep 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ggazzo ggazzo added this to the 6.12 milestone Sep 27, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 27, 2024
@kodiakhq kodiakhq bot merged commit 95a834c into release-6.12.2 Sep 27, 2024
14 of 15 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.12.2-33381 branch September 27, 2024 18:10
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 58.25%. Comparing base (a71d0f0) to head (ea07b1f).
Report is 1 commits behind head on release-6.12.2.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.12.2   #33389      +/-   ##
==================================================
- Coverage           58.71%   58.25%   -0.47%     
==================================================
  Files                2682     2682              
  Lines               65000    65001       +1     
  Branches            14599    14600       +1     
==================================================
- Hits                38167    37866     -301     
- Misses              24357    24372      +15     
- Partials             2476     2763     +287     
Flag Coverage Δ
unit 75.62% <0.00%> (-1.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants