fix: For issue #33354 (email regex validation) #33398
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
In the apps/meteor/lib/emailValidator file, there were issues with how email validation was being handled. Previously, the validation function only checked the part of the email before the "@" symbol. As a result, it incorrectly accepted invalid email addresses like tanu16782@gmail, which is missing the domain suffix.
In this PR, I have updated the code to improve the validation. It now validates the entire email address, including the part after the "." to ensure proper formatting.
Additionally, I addressed issues with the rfcEmailRegex. Previously, it failed to handle certain edge cases, such as accepting empty strings . These cases have now been fixed as part of the update.
Issue(s)
#33354
Steps to test or reproduce
Please refer to #33354 .
Further comments