-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: call button misaligned in the contact information contextual bar #33914
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: eaabbab The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33914 +/- ##
========================================
Coverage 75.20% 75.20%
========================================
Files 495 495
Lines 21595 21595
Branches 5362 5362
========================================
Hits 16240 16240
Misses 4713 4713
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
@aleksandernsilva I don't think its relevant since we're about to merge SCI which is going to change this entire contact view |
Proposed changes (including videos or screenshots)
This PR fixes the call button being misaligned in the contact information contextual bar. The issue seem to have been introduced with the
ButtonGroup
normalization #31499Before:
After:
Issue(s)
Steps to test or reproduce
Workspace > Settings > Omnichannel voice channel (VoIP)
Further comments