feat: disable uploading of exempt apps #33949
Open
+88
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: cc32797 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33949 +/- ##
===========================================
- Coverage 75.19% 75.18% -0.01%
===========================================
Files 495 495
Lines 21601 21600 -1
Branches 5362 5362
===========================================
- Hits 16242 16241 -1
Misses 4717 4717
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Previously community workspaces had the hard limit of 3 private apps, with the private apps restriction, it was defined that community workspaces would not have access to any private apps.
The apps that were already in the workspace, are called exempted.
This PR makes it so that exempt apps cannot be updated, since that would render all the effort of removing community workspaces private apps useless, because the user would be able to just upload the same app while changing everything about it 😢
The 'expect updated private app in CE to be kept as disabled' test was removed since this behavior was changed and now we cannot test that in the CI, since there is no way to upgrade/downgrade it
Issue(s)
Steps to test or reproduce
Further comments
CONN-381
CONN-379