Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove meteor cached collection startup for anons #33975

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Nov 18, 2024

Proposed changes (including videos or screenshots)

Replace meteor code for a hook that loads cached collections of rooms and subscriptions for anonymous users

Issue(s)

Steps to test or reproduce

Further comments

CORE-677

Copy link
Contributor

dionisio-bot bot commented Nov 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 00605db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33975/
on branch gh-pages at 2024-11-18 03:14 UTC

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (66b0e16) to head (b88be23).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33975   +/-   ##
========================================
  Coverage    75.18%   75.18%           
========================================
  Files          495      495           
  Lines        21600    21600           
  Branches      5362     5362           
========================================
  Hits         16241    16241           
  Misses        4717     4717           
  Partials       642      642           
Flag Coverage Δ
unit 75.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review November 18, 2024 17:05
@tiagoevanp tiagoevanp requested a review from a team as a code owner November 18, 2024 17:05
@tiagoevanp tiagoevanp changed the title chore: Remove meteor cached collection startup chore: Remove meteor cached collection startup for anons Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant