Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the slash command /create - to create a new channel #3585

Merged
merged 4 commits into from
Jun 22, 2016

Conversation

Deepakkothandan
Copy link
Contributor

@RocketChat/core

The PR adds a new slash command /open, which creates a new channel.

@rodrigok
Copy link
Member

Why /open and not /create channel?

@Deepakkothandan
Copy link
Contributor Author

I made it to be /open so its compatible with slack

@graywolf336
Copy link
Contributor

It'd be neat if /open #channel-that-exists opens that channel instead of displaying the error message.

Also, may I ask why you've got it returning this return Open; at the end? As I don't think that is required, unless there's something I'm missing

@rodrigok
Copy link
Member

@Deepakkothandan I don't think the /open as the best name if the comment don't open the channel if it already exists, your description for it is Create a new channel while in Slack is Open a channel, so the main goal of this command should be to open a existent channel and if it not exists send user to the channel creation screen.

@rodrigok
Copy link
Member

@Deepakkothandan what do you think? I think that is what the users will expect. 😄

@Deepakkothandan
Copy link
Contributor Author

@rodrigok Thank you for pointing it out, and I misunderstood the slack command, I will rename the command to create and open another PR for /open, ok ?

@rodrigok
Copy link
Member

@Deepakkothandan awesome, thanks 😸

@Deepakkothandan
Copy link
Contributor Author

Deepakkothandan commented Jun 22, 2016

@rodrigok Renamed the command to /create, which is for creating a new channel

@@ -0,0 +1,28 @@
function Create(command, params, item) {
var channel, room, user;
if (command !== 'open' || !Match.test(params, String)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the command here?

@rodrigok
Copy link
Member

@Deepakkothandan can you rename the folder too?

@rodrigok rodrigok changed the title added the slash command /open - to create a new channel added the slash command /create - to create a new channel Jun 22, 2016
@rodrigok
Copy link
Member

LGTM

@rodrigok
Copy link
Member

@RocketChat/core I need one more review here 😸

@sampaiodiego
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants