-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the slash command /create - to create a new channel #3585
added the slash command /create - to create a new channel #3585
Conversation
Why |
I made it to be /open so its compatible with slack |
It'd be neat if Also, may I ask why you've got it returning this |
@Deepakkothandan I don't think the |
@Deepakkothandan what do you think? I think that is what the users will expect. 😄 |
@rodrigok Thank you for pointing it out, and I misunderstood the slack command, I will rename the command to create and open another PR for /open, ok ? |
@Deepakkothandan awesome, thanks 😸 |
@rodrigok Renamed the command to /create, which is for creating a new channel |
@@ -0,0 +1,28 @@ | |||
function Create(command, params, item) { | |||
var channel, room, user; | |||
if (command !== 'open' || !Match.test(params, String)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the command here?
@Deepakkothandan can you rename the folder too? |
LGTM |
@RocketChat/core I need one more review here 😸 |
LGTM |
@RocketChat/core
The PR adds a new slash command /open, which creates a new channel.