Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow owner to delete the room #3773

Merged

Conversation

peccu
Copy link
Contributor

@peccu peccu commented Jul 14, 2016

@RocketChat/core

Closes #1578
(already closed...)

I copied implementations from admin's' room info tab to general room's right tab can access non admin users.

This implementation allows deleting room to user who have delete-* permission.

can-delete
cant-delete

If you want to enable this user, you need to add these permissions to owner or user.

I think there are no owners in direct channel. We have to add delete-d to user.

permissions

@sampaiodiego
Copy link
Member

sampaiodiego commented Jul 21, 2016

I'm ok with this since there is an admin configuration allowing it.
I mean, admins should be able to enable or disable deleting rooms by owners, since them can already archive them.

@peccu
Copy link
Contributor Author

peccu commented Jul 22, 2016

sorry for my poor description...

I only added "DELETE" button to room info tab for non-admin user.

can-delete

I want to permit owner to delete room.

Permissions table is not relative to this PR.

@sampaiodiego
Copy link
Member

Oh, and I'm sorry for not being that clear.
What I tried to say was: I like the feature, but we need to create a setting to admins choose whether they allow owners to delete their rooms or not.

@rodrigok
Copy link
Member

@sampaiodiego yes, so you can go the permissions page and disable that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow room creator to delete that room
4 participants