Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom expiry time setting for Amazon S3 download links #3846

Merged
merged 5 commits into from
Aug 2, 2016

Conversation

iroes
Copy link
Contributor

@iroes iroes commented Jul 23, 2016

@RocketChat/core

Cheap VPSs not always have their clock synced (!!!). And it's not easy to fix as it is usually a restricted system wide setting. Users were receiving this xml from AWS (S3) instead of the file they uploaded:

<Error>
   <Code>AccessDenied</Code>
   <Message>Request has expired</Message>
   <Expires>2016-07-23T09:06:09Z</Expires>
   <ServerTime>2016-07-23T09:40:58Z</ServerTime>
   <RequestId>xxx</RequestId>
   <HostId>
   xxx
   </HostId>
</Error>

I suggest changing the 60 seconds expiry time for links to a longer time, for example 10 minutes. A sysadmin cannot ignore a 10-min-delay complain.

@graywolf336
Copy link
Contributor

@iroes Thanks for the pull request! What about changing it to something that is configurable instead of having it hard coded?

@iroes iroes changed the title Less spartan expiry time for Amazon S3 download links. Custom expiry time setting for Amazon S3 download links Jul 28, 2016
@iroes
Copy link
Contributor Author

iroes commented Jul 28, 2016

Ok @graywolf336, done.

@rodrigok rodrigok merged commit e954c08 into RocketChat:develop Aug 2, 2016
@marceloschmidt marceloschmidt added this to the 0.37.0 milestone Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants