Some improvements from more-streams
#4510
Conversation
| @@ -160,7 +160,7 @@ Template.messagePopup.onCreated -> | |||
|
|
|||
| template.records = new ReactiveVar [] | |||
| Tracker.autorun -> | |||
| if template.data.collection.find? | |||
| if template.data.collection.findOne? | |||
| template.data.collection.find().count() | |||
There was a problem hiding this comment.
Should you use findOne here?
There was a problem hiding this comment.
Also, it looks like it is not doing anything, but I may be wrong for not seeing the whole picture
There was a problem hiding this comment.
@marceloschmidt Yes, cuz array.find is valid too, see here https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/find
There was a problem hiding this comment.
Ok, so in fact you're only checking if that's an array or a mongo collection?
It looked strange that you check for findOne but then use find, that's all. And what does it do template.data.collection.find().count()?
There was a problem hiding this comment.
@marceloschmidt Yes, the count keep the code reactive to list changes
@RocketChat/core