Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show users of room if no view-d-room permission #5154

Closed
wants to merge 2 commits into from

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Dec 8, 2016

@RocketChat/core

Closes #2588

Will not work for branch experimental and it's a client solution only, users still can use console to request a list of other users

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-5154 December 8, 2016 18:39 Inactive
@rodrigok rodrigok changed the title Only show users of room if no view-d-room permission [WIP] Only show users of room if no view-d-room permission Dec 8, 2016
@rodrigok
Copy link
Member Author

rodrigok commented Dec 8, 2016

@RocketChat/core Any ideias here?

@graywolf336
Copy link
Contributor

What if we added another permission, like can-autocomplete-users-not-in-room or something like that?

@rodrigok
Copy link
Member Author

rodrigok commented Dec 8, 2016

@sampaiodiego This is not exactly what that issue require, this limit the autocomplete for "guest" users

@engelgabriel engelgabriel changed the title [WIP] Only show users of room if no view-d-room permission Only show users of room if no view-d-room permission Dec 13, 2016
@hussamEddinAlhendi
Copy link
Contributor

hussamEddinAlhendi commented Jan 19, 2017

@rodrigok I want to start implement this in server side but I'm new on Rocket.Chat so do have any instructions to do this

@geekgonecrazy
Copy link
Contributor

Fixed by #7830

@geekgonecrazy geekgonecrazy deleted the guest-autocomplete branch April 18, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit autocompleting names in private channels to those in the channel
5 participants