Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/delete user unexpected error #5199

Closed
wants to merge 12 commits into from
Closed

Bugfix/delete user unexpected error #5199

wants to merge 12 commits into from

Conversation

KindOf
Copy link

@KindOf KindOf commented Dec 13, 2016

@RocketChat/core

There was an Error when invoking /api/v1/users.delete:
TypeError: first argument must be a string or Buffer
at ServerResponse.OutgoingMessage.write (_http_outgoing.js:459:11)
at ServerResponse.res.write (/app/bundle/programs/server/npm/node_modules/meteor/webapp/node_modules/compression/index.js:80:17)
at sendResponse (/app/bundle/programs/server/packages/nimble_restivus.js:451:16)
at Route.share.Route.Route._respond (/app/bundle/programs/server/packages/nimble_restivus.js:460:14)
at /app/bundle/programs/server/packages/nimble_restivus.js:250:25
at packages/simple_json-routes.js:98:9

Fixed it by adding response body according to API docs

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ RomanKisilenko
❌ Igor O


Igor O seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@graywolf336
Copy link
Contributor

@KindOf Thank you for this pull request, however the documentation is against the latest version of Rocket.Chat and not the version which you submitted a pull request against. The pull request which added the functionality in the documentation was #5140.

Also, you might want to change your AWS keys as you checked in your build script with all your keys in it.

@KindOf KindOf deleted the bugfix/delete-user-unexpected-error branch December 13, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants