Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing username by admin #699

Merged
merged 4 commits into from
Sep 7, 2015
Merged

changing username by admin #699

merged 4 commits into from
Sep 7, 2015

Conversation

soonahn
Copy link
Contributor

@soonahn soonahn commented Sep 5, 2015

Addresses #698

@geekgonecrazy
Copy link
Contributor

This also looks solid. Going to test both this and #696. The underlying method hasn't been tested fully.

@engelgabriel
Copy link
Member

Guys, update the username is not that simple. You need to use the method. There are a lot of checking and references that need o be updated together, not just the users collection.

@engelgabriel
Copy link
Member

Need to call /packages/rocketchat-lib/server/methods/setUsername.coffee

@soonahn
Copy link
Contributor Author

soonahn commented Sep 5, 2015

Updated so the update method is only called once. New to meteor, didn't realise that was possible. Thanks!

@soonahn soonahn closed this Sep 5, 2015
@engelgabriel
Copy link
Member

I think this should be done, but using the right method call

@engelgabriel engelgabriel reopened this Sep 6, 2015
@soonahn
Copy link
Contributor Author

soonahn commented Sep 6, 2015

@engelgabriel fixed to use the setUsername method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants