Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] do only store password if LDAP_Login_Fallback is on #7030

Merged
merged 3 commits into from
May 31, 2017

Conversation

pmb0
Copy link
Contributor

@pmb0 pmb0 commented May 19, 2017

@RocketChat/core
@TwizzyDizzy

See #6144

Comment by TwizzyDizzy

We do NOT want passwords to be saved in MongoDB when LDAP is enabled (this might be made into an option in the backend, if not, they should not be saved by default)
unless fallback-login is activated
this means the passwords need to be erased (for LDAP-flagged accounts) on disabling fallback login and stored on next login, when this feature is enabled

This PR changes the password storage behaviour if LDAP_Login_Fallback is enabled. The password will not be saved in MongoDB.

@CLAassistant
Copy link

CLAassistant commented May 19, 2017

CLA assistant check
All committers have signed the CLA.

@pmb0 pmb0 changed the title [FIX] do not store password if LDAP_Login_Fallback is off [FIX] do not store password if LDAP_Login_Fallback is on May 19, 2017
@pmb0 pmb0 changed the title [FIX] do not store password if LDAP_Login_Fallback is on [FIX] do only store password if LDAP_Login_Fallback is on May 19, 2017
@magicbelette
Copy link
Contributor

Rocket.Chat Version: 0.57.1

Passwords are still stored when create new user :

// Create new user
return addLdapUser(ldapUser, username, loginRequest.ldapPass);

Need to check "LDAP_Login_Fallback" setting again :

if (RocketChat.settings.get('LDAP_Login_Fallback') === true) {
   return addLdapUser(ldapUser, username, loginRequest.ldapPass);        
} else {
   return addLdapUser(ldapUser, username);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants