[NEW] Feature/livechat hide email

[icosamuel]

@RocketChat/core
@RocketChat/livechat
Closes #6612

New Livechat_show_agent_email config in the livechat tab of the web administration page as well as the Livechat management page, translated in en and fr.

The emails are not loaded from the database when we query for agent data, so they are never sent to the client.

[CLAassistant]

All committers have signed the CLA.

[RichGriese]

I just set up a Beta Rocket & am playing with LiveChat. In testing the operator email is showing. Is it too new to see this fix/mod in the beta, or is there some other issue? I see that the issues in still open. But it looks like the chatter indicates it's been done. I guess this is my intro in follow an issue through the process. Cheers!

[icosamuel]

Hey @RichGriese! glad to see youre interested in this feature as well!

Unfortunately, I don't think we will see this in the next few releases, since it's going into the 0.60 feature bag, and the rocketchat pipeline is still making release candidates for 0.59

What I personally do to cherry pick the features that are not out yet, is to keep my own version of the project. If you have the resources, you can build the project after integrating this branch, or just build the project on my develop branch ;)

Hope this helps, I cant wait to get this feature out in the open!

[icosamuel]

@sampaiodiego I realize that this is a minor feature, and that you might have a lot of different priorities.
With that said, may I request a review? I consider my work done and would like to close this PR.
Thanks for your time and help :)

[sampaiodiego]

hi @icosamuel .. thank you very much for another contribution.

indeed it was a minor feature I was able to test between other tasks. =)

so far it looks good, but I noticed it is still sending agent's email over the wire (but correctly not showing it depending on the setting). what you think on preventing the email field to be sent to the client instead of just not showing it? TIA

[alexweissman]

It would be ideal avoid sending the agent's email over the wire, but simply hiding it for now would be acceptable for the sake of getting this patched into the next release. It's a fairly significant privacy issue, especially for those of us with agents who didn't know that their email address would become public information in the context of livechat.

I'd say, merge this as-is for the 0.59 release, then update to avoid sending the email to the client at all in 0.60.

[icosamuel]

sure, now that I'm more comfortable with the project, I can more easily change it's behavior to be on the server side.

It'll take some time though, as the requirements are kind of met on our side, so my time mostly goes on other tasks :/

[alexweissman]

@icosamuel the great tragedy of open source 😛

[icosamuel]

Finally, I've found some time to sort this issue out! As of now, the emails do not even get out of the database if the setting is active.

This approach leaves us with much simpler changes and an elegant solution which does not even involve the Livechat client!