Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Sidebar and RTL alignments #8154

Merged
merged 4 commits into from
Sep 18, 2017
Merged

[FIX] Sidebar and RTL alignments #8154

merged 4 commits into from
Sep 18, 2017

Conversation

karlprieb
Copy link
Contributor

@karlprieb karlprieb commented Sep 14, 2017

@RocketChat/core

Closes #8148 #8129 #8165 #8179 #8184 #8185 #8182

Sidebar:

  • Removed empty space above sidebar header
  • Fixed header color on lighten version of the sidebar
  • Fixed empty room groups alignment
  • Fixed livechat icon alignment
  • Fixed Back button alignment

Create Channel:

  • Fixed create channel page on mobile
  • Now private channels are default

Popover:

  • Fixed popover position on RTL

image

image

image

image

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8154 September 14, 2017 21:54 Inactive
@rodrigok rodrigok added this to the 0.59.0-rc.6 milestone Sep 14, 2017
@rodrigok
Copy link
Member

image

@rodrigok
Copy link
Member

The popover when click on + icon is going out of the screen

@rodrigok
Copy link
Member

When creating a new room, the initial label of the room type switch is wrong

image

@rodrigok
Copy link
Member

On create room screen and using RTL the switch layout is broken and the label is very near to the switch

image

@cyclops24
Copy link
Contributor

@rodrigok, @karlprieb Please visit #8175

@karlprieb
Copy link
Contributor Author

@rodrigok thank for you report :)
It's fixed!

image

image

2017-09-18 14 06 19

@faziloub
Copy link

@karlprieb did you fixed the height of sidenav in admin ?? and profile height for mobile?? becaus its has even issue on scroll

@cyclops24
Copy link
Contributor

@karlprieb #8182 not fixed with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar Account alignments
6 participants