Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block message editing based on admin settings #833

Merged
merged 6 commits into from
Sep 21, 2015
Merged

Conversation

gmsecrieru
Copy link
Contributor

This pull request should close issue #44

  • Added Message_AllowEditing_BlockEditInMinutes (int) admin option
  • Applying changes on code base to reflect this option.

@rodrigok
Copy link
Member

Is this enabled by default?
There is an option to enable editing forever?

@gmsecrieru
Copy link
Contributor Author

@rodrigok I've changed the default value of Message_AllowEditing_BlockEditInMinutes to 0, which will be considered to be disabled as you suggested on #44 (missed this scenario -- my bad!). Application logic was also updated to reflect these changes!

rodrigok added a commit that referenced this pull request Sep 21, 2015
Block message editing based on admin settings
@rodrigok rodrigok merged commit ac5223a into master Sep 21, 2015
@rodrigok rodrigok deleted the block-msg-editing branch September 21, 2015 19:48
Shailesh351 pushed a commit to Shailesh351/Rocket.Chat that referenced this pull request Aug 17, 2021
…nt_fix_2

fix case where VA timer does not start until the visitor sends a mess…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants