Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified find for autocomplete to show usernames that begin your input #848

Merged
merged 2 commits into from
Sep 21, 2015

Conversation

geekgonecrazy
Copy link
Contributor

Currently the situation is something like this:

image

That first user should not be even displayed. If i'm typing @ something. I would expect it to only match beginning with what i've typed. Otherwise its more of a search then a completion.

@geekgonecrazy
Copy link
Contributor Author

Also should name even be checked? I would think it'd only check username. Because you can't do @ Aaron Ogle you have to do @geekgonecrazy

@RocketChat/owners what do you guys think?

@dbussert
Copy link

My 2 cents, a team working together in-real-life will remember people by their real name, not their username. Slack nails this one with auto-completion via username or real name.

@geekgonecrazy
Copy link
Contributor Author

@dbussert doesn't it always show their username as the sender of messages though?

@dbussert
Copy link

@geekgonecrazy, if you're replying directly to a message, you will inherently see their username, and its very easy to do a @username. But if you're typing a new message to get their attention, you very likely may want to use a real name, since you don't have their username already in front of you. Having real name support is also very good for newbies who might not know all the usernames by heart, but do know the person they are trying to address.

@rodrigok
Copy link
Member

@geekgonecrazy I agree with @dbussert and Slack matches last name too

@geekgonecrazy
Copy link
Contributor Author

@dbussert @rodrigok ok that's fine by me. I'm good with it as long as the autocomplete is actually useful instead of a nuisance. So as long as its pushing what is most likely a match to the top i'll be happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants