[FIX] Show real name of current user at top of side nav if setting enabled #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekgonecrazy
approved these changes
Nov 6, 2017
ggazzo
reviewed
Nov 6, 2017
| @@ -6,7 +6,11 @@ | |||
| {{> avatar username=username}} | |||
| </div> | |||
| <div class="sidebar__account-data"> | |||
| <h3 class="sidebar__account-username" data-username="{{username}}">@{{username}}</h3> | |||
| {{#if fname}} | |||
There was a problem hiding this comment.
I think we should use a helper here instead an if and the same html.. what do you think @geekgonecrazy ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Restore full name in left nav bar if UI_Use_Real_Name setting enabled.