-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add "real name change" setting #8739
[NEW] Add "real name change" setting #8739
Conversation
c4981c7
to
faf3a3b
Compare
@AmShaegar13 Thanks for this PR. Usually guys fill English and omit other languages for translators. |
faf3a3b
to
4f21890
Compare
4f21890
to
c99fe59
Compare
fba683a
to
323fad9
Compare
I added some tests to ensure it's working as intended. Should be ready to merge after checks are green. |
Thanks for your PR, we'll review it and provide feedback when possible. |
My new tests are failing. I am still searching for a clever way to make them pass reliably. |
ae4c273
to
46baaea
Compare
46baaea
to
16a4fd4
Compare
Okay, tests are green. I am done. :) |
@AmShaegar13 approved ;) |
I see this is still open; has it been merged at all, or could it be? If working, it s something our users would like. In our case we have disabled Profile changes, but would like Avatar changes still, so that may not be part of what was originally scoped here. |
@dajoker This PR was merged and is not open anymore. You can use it from Administration -> Account -> Allow Name Change |
@RocketChat/core
Closes #8576
Added a setting to allow real name updates. This was necessary after avatar updating was merged into profile page. One could not allow avatar updates while forbidding name changes (implicitly with fobidding profile updates at all). I used the exact same logic as the username setting does.
Just one question: How about the languages I do not speak? Do I just omit them or fill i18n JSONs with placeholders?