Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Empty sidenav when sorting by activity and there is a subscription without room #9960

Merged
merged 5 commits into from
Mar 3, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 1, 2018

@RocketChat/core

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9960 March 1, 2018 18:53 Inactive
@ggazzo ggazzo force-pushed the hotfix-subscription-without-room-ui branch from ab890ea to 767b386 Compare March 1, 2018 19:03
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9960 March 1, 2018 19:04 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9960 March 1, 2018 20:04 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9960 March 2, 2018 12:45 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9960 March 2, 2018 13:18 Inactive
@rodrigok rodrigok changed the title [FIX] fixed crash on ui when there are subscriptions without room [FIX] Menu show nothing when sorted by activity and there are subscriptions without room Mar 2, 2018
@rodrigok rodrigok added this to the 0.62.1 milestone Mar 2, 2018
@sampaiodiego sampaiodiego changed the title [FIX] Menu show nothing when sorted by activity and there are subscriptions without room [FIX] Empty sidenav when sorting by activity and there is a subscription without room Mar 3, 2018
@sampaiodiego sampaiodiego merged commit 24b0c95 into develop Mar 3, 2018
@sampaiodiego sampaiodiego deleted the hotfix-subscription-without-room-ui branch March 3, 2018 00:49
sampaiodiego added a commit that referenced this pull request Mar 3, 2018
…room-ui

[FIX] Empty sidenav when sorting by activity and there is a subscription without room
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
trongthanh added a commit to goalifyplus/Goalify.Chat that referenced this pull request Apr 9, 2018
* master:
  Revise test job, fix cache path, fix artifact path, update README
  Trying to fix memory issue during meteor build
  Add S3 upload script
  Remove root-priviledged command
  switch gitlab ci config to use shell executor
  Try another build
  Fix another stupid docker image reference
  try to fix a build error with katex
  Fix root permission for meteor command everywhere
  Try to fix build with gitlab-ci
  Add --allow-superuser to fix meteor build error on root permission
  First try with a gitlab-ci build
  Bump version to 0.62.1
  Merge pull request RocketChat#9986 from RocketChat/hotfix/user-delete-without-username
  Merge pull request RocketChat#9988 from RocketChat/fix-new-channel
  Merge pull request RocketChat#9960 from RocketChat/hotfix-subscription-without-room-ui
  Merge pull request RocketChat#9982 from RocketChat/fix-two-factor-login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants