Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: New nosecone types added. #339

Merged
merged 1 commit into from
Mar 16, 2023
Merged

ENH: New nosecone types added. #339

merged 1 commit into from
Mar 16, 2023

Conversation

CabGT
Copy link
Contributor

@CabGT CabGT commented Mar 11, 2023 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Only a few types of nosecones were supported with Cp calculations.

What is the new behavior?

Elliptical and tangent types of nosecone added following the theory on THE DESCRIPTIVE GEOMETRY OF NOSE CONES, 1996, Gary A. Crowell Sr.

Now we have the value "k" for these nosecone in order to be able to calculate its center of pressure.

Also checked that Von Karman and parabolic types are covered on the else statement. k = 0.5
Therefore, the documentation was update stating that the code support elliptical, parabolic, von Karman and tangent nosecones.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@MateusStano MateusStano added Enhancement New feature or request, including adjustments in current codes Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic labels Mar 11, 2023
@MateusStano MateusStano added this to the Release v1.0.0 milestone Mar 11, 2023
Gui-FernandesBR
Gui-FernandesBR approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple to review, and very useful addition.

Well done, @CabGT !!

It's a go for merge from my side.

@MateusStano MateusStano merged commit 1c60fda into enh/aerodynamic_surfaces_parent_class Mar 16, 2023
MateusStano added a commit that referenced this pull request Apr 9, 2023
@MateusStano
Squashed commit of the following:
1e2f471 
commit 1bf4851
Merge: c3c20d0 0636108
Author: MateusStano <[email protected]>
Date:   Sun Apr 9 13:58:17 2023 -0300

    Merge pull request #334 from RocketPy-Team/enh/Function-operations

    ENH: Function Operations

commit 0636108
Author: Pedro Bressan <[email protected]>
Date:   Mon Apr 3 23:20:12 2023 -0300

    ENH: add second order derivatives.

    Co-authored-by: giovaniceotto <[email protected]>

commit 1d39356
Author: Pedro Bressan <[email protected]>
Date:   Mon Apr 3 22:22:54 2023 -0300

    ENH: reimplement bijection checks from 10bf4cd

commit d5c4eab
Author: Pedro Bressan <[email protected]>
Date:   Mon Apr 3 21:47:45 2023 -0300

    MAINT: update inverseFunction docstrings.

commit 7847e45
Author: Pedro Bressan <[email protected]>
Date:   Mon Apr 3 21:41:20 2023 -0300

    FIX: handle all composition cases in compose.

commit e5eefae
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Sat Apr 1 23:15:59 2023 -0300

    FIX: fix left over bug in spline integral when bounds are out of domain

commit 2024ab5
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Sat Apr 1 23:15:17 2023 -0300

    TST: Improve Function.integral tests

commit 217741e
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Thu Feb 2 17:34:34 2023 +0000

    MAINT: refactor linear interpolated Function integral

commit 4f11816
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Sat Apr 1 22:29:43 2023 -0300

    FIX: solves spline integration errors

commit e7c2d98
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Sat Apr 1 22:27:50 2023 -0300

    TST: Create Function.integral tests for splines

commit c3c20d0
Merge: 35eca94 c255e1c
Author: MateusStano <[email protected]>
Date:   Fri Mar 31 23:58:44 2023 -0300

    Merge pull request #346 from RocketPy-Team/fix/flight-reynolds-dynamic-viscosity

    Fix: Flight Reynolds & Dynamic viscosity wrong values

commit 35eca94
Merge: 6a09af6 986666d
Author: MateusStano <[email protected]>
Date:   Fri Mar 31 23:58:24 2023 -0300

    Merge pull request #347 from RocketPy-Team/tst/flutter-test-fix

    TST: Flutter test fix

commit c255e1c
Merge: fea5662 986666d
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Fri Mar 31 22:54:53 2023 -0300

    Merge branch 'tst/flutter-test-fix' into fix/flight-reynolds-dynamic-viscosity

commit 986666d
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Fri Mar 31 22:48:25 2023 -0300

    TST: decrease assertion requirements for flutter test

    Co-authored-by: MateusStano <[email protected]>
    Co-authored-by: phmbressan <[email protected]>

commit fea5662
Author: Giovani Hidalgo Ceotto <[email protected]>
Date:   Fri Mar 31 22:39:05 2023 -0300

    FIX: change index from 7 to 8 to fix dynamic viscosity

    Co-authored-by: MateusStano <[email protected]>
    Co-authored-by: phmbressan <[email protected]>

commit afa44d6
Author: MateusStano <[email protected]>
Date:   Fri Mar 31 15:45:15 2023 -0300

    ENH: added integral changes from #332

commit 165bb27
Author: Lint Action <[email protected]>
Date:   Wed Mar 29 12:30:49 2023 +0000

    Fix code style issues with Black

commit 7f40fda
Author: Pedro Bressan <[email protected]>
Date:   Wed Mar 29 09:27:58 2023 -0300

    FIX: array attributes error on setDiscrete conversion.

commit d9af5fe
Author: Pedro Bressan <[email protected]>
Date:   Wed Mar 29 08:40:32 2023 -0300

    ENH: implement compose method for array based Functions.

commit 3ddfecb
Merge: b822714 1126751
Author: MateusStano <[email protected]>
Date:   Mon Mar 27 15:07:09 2023 -0300

    Merge branch 'enh/Function-operations' of https://github.com/RocketPy-Team/RocketPy into enh/Function-operations

commit b822714
Author: MateusStano <[email protected]>
Date:   Mon Mar 27 15:07:03 2023 -0300

    MAINT: more docs

commit 1126751
Author: Lint Action <[email protected]>
Date:   Mon Mar 27 17:39:47 2023 +0000

    Fix code style issues with Black

commit d851457
Merge: 1d1b2ba 6a09af6
Author: MateusStano <[email protected]>
Date:   Mon Mar 27 14:37:17 2023 -0300

    Merge branch 'beta/v1.0.0' into enh/Function-operations

commit 1d1b2ba
Author: MateusStano <[email protected]>
Date:   Mon Mar 27 14:25:11 2023 -0300

    MAINT: improved/corrected docs

commit 3550b0f
Author: MateusStano <[email protected]>
Date:   Mon Mar 27 13:36:01 2023 -0300

    ENH: improved new methods

commit 8b78bb5
Author: MateusStano <[email protected]>
Date:   Mon Mar 27 13:24:03 2023 -0300

    enh: added __bool__ dunder method

commit c3c4617
Author: MateusStano <[email protected]>
Date:   Sun Mar 26 20:05:52 2023 -0300

    enh: added self.xArray and self.yArray

commit 6a09af6
Merge: 483d9cf 803e2f8
Author: MateusStano <[email protected]>
Date:   Wed Mar 22 15:18:30 2023 -0300

    Merge pull request #342 from RocketPy-Team/enh/aerodynamic_surfaces_parent_class

    Enh/aerodynamic surfaces parent class

commit 803e2f8
Author: Lint Action <[email protected]>
Date:   Wed Mar 22 18:17:51 2023 +0000

    Fix code style issues with Black

commit db653ac
Merge: d9cf063 483d9cf
Author: MateusStano <[email protected]>
Date:   Wed Mar 22 15:17:27 2023 -0300

    Merge branch 'beta/v1.0.0' into enh/aerodynamic_surfaces_parent_class

commit d9cf063
Author: MateusStano <[email protected]>
Date:   Wed Mar 22 15:13:02 2023 -0300

    ENH: improve nose and tail prints

commit 5c9d77f
Merge: 1c60fda 794226d
Author: MateusStano <[email protected]>
Date:   Wed Mar 22 14:50:04 2023 -0300

    Merge pull request #341 from RocketPy-Team/enh/Change_aeroSurfaces_class

    Enh/change aero surfaces class

commit 794226d
Author: MateusStano <[email protected]>
Date:   Wed Mar 22 14:43:07 2023 -0300

    enh: changed __str__ back to __repr__
    added "->"

commit 1bc9227
Author: Lint Action <[email protected]>
Date:   Mon Mar 20 16:41:27 2023 +0000

    Fix code style issues with Black

commit 98534e5
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Mon Mar 20 13:40:03 2023 -0300

    running black

commit 1cbd52a
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Mon Mar 20 13:37:08 2023 -0300

    changing __repr__ to __str__

commit 1c60fda
Merge: 438074a aa6e68d
Author: MateusStano <[email protected]>
Date:   Thu Mar 16 20:05:56 2023 -0300

    Merge pull request #339 from RocketPy-Team/enh/new-nosecone-types-added

    ENH: New nosecone types added.

commit aa6e68d
Author: CabGT <[email protected]>
Date:   Sat Mar 11 17:35:37 2023 -0300

    ENH: New nosecone types added.

commit 9dd94aa
Author: MateusStano <[email protected]>
Date:   Thu Mar 9 15:19:58 2023 -0300

    enh: remade position an input for the aeroSurfaces list
    made position also save in the object

commit ecaa167
Author: Pedro Bressan <[email protected]>
Date:   Thu Feb 23 14:05:44 2023 -0300

    ENH: add average operation and minor fixes.

commit 2676e44
Author: Pedro Bressan <[email protected]>
Date:   Thu Feb 23 14:04:58 2023 -0300

    MAINT: use scipy.root as faster root finder.

commit 0ccf225
Author: Pedro Bressan <[email protected]>
Date:   Thu Feb 23 14:04:00 2023 -0300

    FIX: correct compose operation.

commit 4020cdd
Author: MateusStano <[email protected]>
Date:   Tue Feb 21 13:17:02 2023 -0300

    enh: create nosecone, fins and tail attribute

commit 438074a
Merge: a2505dd b929456
Author: MateusStano <[email protected]>
Date:   Sun Feb 19 19:09:19 2023 -0300

    Merge pull request #333 from RocketPy-Team/enh/setters_and_getters

    Enh/setters and getters

commit b929456
Author: MateusStano <[email protected]>
Date:   Sun Feb 19 19:02:24 2023 -0300

    maint: tidy up docs

commit c803668
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Sat Feb 18 12:53:16 2023 -0300

    enh: making position an atribute of the aero classes

commit a2505dd
Merge: db066ad e9b7422
Author: MateusStano <[email protected]>
Date:   Sat Feb 18 12:05:01 2023 -0300

    Merge pull request #327 from RocketPy-Team/enh/plot-airfoil-information

    enh/plot-airfoil-information

commit e9b7422
Author: Lint Action <[email protected]>
Date:   Sat Feb 18 15:03:24 2023 +0000

    Fix code style issues with Black

commit 696d631
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Sat Feb 18 12:02:55 2023 -0300

    enh:airfoilInfo

commit ff8ae3d
Author: Lint Action <[email protected]>
Date:   Sat Feb 18 01:09:05 2023 +0000

    Fix code style issues with Black

commit 1ee3c15
Author: FranzYuri <[email protected]>
Date:   Fri Feb 17 22:08:58 2023 -0300

    Update rocketpy/AeroSurfaces.py

    Co-authored-by: MateusStano <[email protected]>

commit 5f421c5
Author: FranzYuri <[email protected]>
Date:   Fri Feb 17 22:08:37 2023 -0300

    Update rocketpy/AeroSurfaces.py

    Co-authored-by: MateusStano <[email protected]>

commit 9064685
Merge: b238174 8b57822
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Fri Feb 17 22:01:44 2023 -0300

    Merge branch 'enh/setters_and_getters' of https://github.com/RocketPy-Team/RocketPy into enh/setters_and_getters

commit b238174
Merge: e1c4afe 10658c7
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Fri Feb 17 22:01:20 2023 -0300

    Merge branch 'enh/setters_and_getters' of https://github.com/RocketPy-Team/RocketPy into enh/setters_and_getters

commit 8b57822
Author: Lint Action <[email protected]>
Date:   Sat Feb 18 01:01:16 2023 +0000

    Fix code style issues with Black

commit e1c4afe
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Fri Feb 17 22:01:07 2023 -0300

    finishing setters

commit 10658c7
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Fri Feb 17 22:00:42 2023 -0300

    finishing setters

commit efc1c9f
Author: giovaniceotto <[email protected]>
Date:   Thu Feb 16 00:59:20 2023 -0300

    STY: apply black linting

commit 882921f
Author: giovaniceotto <[email protected]>
Date:   Thu Feb 16 00:58:23 2023 -0300

    MAINT: refactor integralFunction method

commit 10bf4cd
Author: giovaniceotto <[email protected]>
Date:   Thu Feb 16 00:46:17 2023 -0300

    ENH: implement Function.isStrictlyBijective

commit 4150015
Author: Pedro Bressan <[email protected]>
Date:   Tue Feb 14 17:09:37 2023 -0300

    maint: linting with black.

commit 0418dc4
Author: Pedro Bressan <[email protected]>
Date:   Tue Feb 14 17:07:48 2023 -0300

    maint: update docstrings and method naming.

commit 957352a
Author: Pedro Bressan <[email protected]>
Date:   Tue Feb 14 17:06:31 2023 -0300

    add: update inverseFunction with bijection checks.

commit 90894d0
Author: Pedro Bressan <[email protected]>
Date:   Tue Feb 14 17:05:40 2023 -0300

    add: method that checks whether a Function is bijective.

commit 029c57a
Merge: a9f9fab 66bd7e6
Author: phmbressan <[email protected]>
Date:   Mon Feb 13 22:37:42 2023 -0300

    Merge pull request #330 from Space-Enterprise-at-Berkeley/enh/function-updates

    Added Piecewise class and other new Function methods

commit 8e17bc2
Author: Lint Action <[email protected]>
Date:   Sat Feb 11 22:54:39 2023 +0000

    Fix code style issues with Black

commit 1318e39
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Sat Feb 11 19:47:43 2023 -0300

    minor improvements

commit 66bd7e6
Author: gautam <[email protected]>
Date:   Sat Feb 11 11:26:15 2023 -0800

    updated inverseFunction

commit 98ba965
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Fri Feb 10 19:35:42 2023 -0300

    adding methods to the Fins classes

    adding methods to the fins classes

commit 46ecbd1
Author: gautamsaiy <[email protected]>
Date:   Wed Feb 8 15:00:51 2023 -0800

    Update rocketpy/Function.py

    Improved documentation

    Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>

commit cdc05f3
Author: gautamsaiy <[email protected]>
Date:   Wed Feb 8 15:00:30 2023 -0800

    Update rocketpy/Function.py

    Improved documentation

    Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>

commit 9bc25ba
Author: gautamsaiy <[email protected]>
Date:   Wed Feb 8 15:00:02 2023 -0800

    Update rocketpy/Function.py

    changed invert method name to inverseFunction and improved documentation

    Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>

commit ce84770
Author: gautam <[email protected]>
Date:   Sun Feb 5 10:53:56 2023 -0800

    Fixed a small error

commit d888f6f
Author: gautamsaiy <[email protected]>
Date:   Sat Feb 4 11:32:15 2023 -0800

    Update rocketpy/Function.py

    Changed output from ndarray to float

    Co-authored-by: phmbressan <[email protected]>

commit d9c3980
Author: gautamsaiy <[email protected]>
Date:   Sat Feb 4 11:31:45 2023 -0800

    Update rocketpy/Function.py

    Added try/except block to invert method

    Co-authored-by: phmbressan <[email protected]>

commit db066ad
Merge: d572bcc b488ac5
Author: MateusStano <[email protected]>
Date:   Sun Jan 29 23:07:03 2023 -0300

    Merge pull request #329 from RocketPy-Team/enh/fix_legends

    enh/fix_legends

commit 356ef4c
Author: gautam <[email protected]>
Date:   Sat Jan 28 17:04:39 2023 -0800

    Added Piecewise class and other new Function methods

commit 2e6dc28
Author: Lint Action <[email protected]>
Date:   Thu Jan 26 20:33:43 2023 +0000

    Fix code style issues with Black

commit d4a661e
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Thu Jan 26 17:08:44 2023 -0300

    only added one plot

commit b488ac5
Author: Franz Masatoshi Yuri <[email protected]>
Date:   Wed Jan 25 17:47:41 2023 -0300

    fixed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/new-nosecone-types-added branch April 10, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gui-FernandesBR Gui-FernandesBR Gui-FernandesBR approved these changes

@MateusStano MateusStano MateusStano approved these changes

@giovaniceotto giovaniceotto Awaiting requested review from giovaniceotto

Assignees

@CabGT CabGT

Labels
Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic Enhancement New feature or request, including adjustments in current codes
Projects
None yet
Milestone
Release v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CabGT @Gui-FernandesBR @MateusStano