Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Rotational EOMs Not Relative To CDM #674

Merged
merged 12 commits into from
Aug 25, 2024

Conversation

MateusStano
Copy link
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Info

There were two errors with calculations of the u_dot and u_dot_generalized

  1. The moments generated by the aerodynamic surfaces was calculated relative to the instantaneous center of mass, instead of the center of dry mass
  2. The inertias were being calculate relative tot the instatneous centero fmass, instead of relative tot he center of dry mass

The first error has been in the code since da91db9 aka the first ever commit!

Special thanks to @kevin-alcaniz for finding this

@MateusStano MateusStano added the Flight Flight Class related features label Aug 20, 2024
@MateusStano MateusStano self-assigned this Aug 20, 2024
@MateusStano MateusStano requested a review from a team as a code owner August 20, 2024 21:25
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (1664d78) to head (3a4c742).
Report is 7 commits behind head on develop.

Files Patch % Lines
rocketpy/simulation/flight.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #674      +/-   ##
===========================================
- Coverage    75.95%   75.87%   -0.08%     
===========================================
  Files           85       85              
  Lines        10079    10085       +6     
===========================================
- Hits          7655     7652       -3     
- Misses        2424     2433       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rocketpy/rocket/rocket.py Outdated Show resolved Hide resolved
docs/user/rocket/rocket_usage.rst Outdated Show resolved Hide resolved
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rocketpy/simulation/flight.py Show resolved Hide resolved
@Gui-FernandesBR Gui-FernandesBR merged commit 6d65fa9 into develop Aug 25, 2024
8 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/rotational-eoms-not-relative-to-cdm branch August 25, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flight Flight Class related features
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants