Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Zero Mass Flow Tank causing Empty Velocity Data #677

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Adding a Tank with zero mass flow rate at all times causes an error on exhaust_velocity computation.

New behavior

Zeros were added as defaults to the exhaust_velocity calculation and the total_mass_flow_rate formula as changed to an identical one that avoids possible zero divisions errors.

Breaking change

  • Yes
  • No

@phmbressan phmbressan added the Bug Something isn't working label Aug 30, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Aug 30, 2024
@phmbressan phmbressan self-assigned this Aug 30, 2024
@phmbressan phmbressan requested a review from a team as a code owner August 30, 2024 21:02
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (3a4c742) to head (1a16b14).
Report is 44 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #677      +/-   ##
===========================================
- Coverage    75.87%   74.46%   -1.41%     
===========================================
  Files           85       89       +4     
  Lines        10085    10368     +283     
===========================================
+ Hits          7652     7721      +69     
- Misses        2433     2647     +214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR merged commit ed296d6 into develop Sep 8, 2024
5 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/zero-mass-flow-motor branch September 8, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants