Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Rollback Prandtl-Glauert corrections for Tail and Nose. #685

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Prandtl-Glauert corrections applied to Tail and Nose produced some unexpected behaviors.

New behavior

This PR rollback the Tail and Nose aerodynamic to the earlier state.

Breaking change

  • Yes
  • No

@phmbressan phmbressan added Bug Something isn't working Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic labels Sep 9, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Sep 9, 2024
@phmbressan phmbressan self-assigned this Sep 9, 2024
@phmbressan phmbressan requested a review from a team as a code owner September 9, 2024 12:18
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.74%. Comparing base (174aee5) to head (4de4c95).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   75.74%   75.74%           
=======================================
  Files          81       81           
  Lines        9821     9821           
=======================================
  Hits         7439     7439           
  Misses       2382     2382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite important to mention that this PR revert #609 ... which was made to solving #133

@Gui-FernandesBR
Copy link
Member

For the future... We should allow users to decide if they want their models to follow one assumption or another.

@phmbressan phmbressan merged commit c062212 into master Sep 11, 2024
11 checks passed
@phmbressan phmbressan deleted the bug/prandtl-glauert-rollback branch September 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic Bug Something isn't working
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants