Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix Motor Zero Dry Mass Check #710

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

laurapgp
Copy link
Contributor

@laurapgp laurapgp commented Oct 9, 2024

fixed zero mass check for motor dry_mass. Local tests are passing.

@laurapgp laurapgp requested a review from a team as a code owner October 9, 2024 14:00
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for the tests on CI,

Please update the CHANGELOG.

The setter is not checking for negative mass values. I understand it's not the focus of this PR. We can improve it in the future.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (8e4db26) to head (eb3ad14).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #710      +/-   ##
===========================================
+ Coverage    75.90%   75.93%   +0.02%     
===========================================
  Files           99       99              
  Lines        11222    11222              
===========================================
+ Hits          8518     8521       +3     
+ Misses        2704     2701       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phmbressan phmbressan changed the title BUG: fix zero mass check BUG: Fix Motor Zero Dry Mass Check Oct 9, 2024
@phmbressan phmbressan merged commit dde7ba4 into develop Oct 9, 2024
5 checks passed
@phmbressan phmbressan deleted the bug/zero-mass-is-not-none branch October 9, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants