Skip to content

Commit

Permalink
Merge pull request #68 from derskythe/fixed-archive-app
Browse files Browse the repository at this point in the history
Fixed archive app
  • Loading branch information
xMasterX authored Sep 15, 2022
2 parents e23dbb9 + df87b04 commit 3a1705b
Show file tree
Hide file tree
Showing 13 changed files with 496 additions and 131 deletions.
97 changes: 70 additions & 27 deletions applications/main/archive/archive.c
Original file line number Diff line number Diff line change
@@ -1,79 +1,122 @@
#include "archive_i.h"
#include "m-string.h"

bool archive_custom_event_callback(void* context, uint32_t event) {
static bool archive_custom_event_callback(void* context, uint32_t event) {
furi_assert(context);
ArchiveApp* archive = (ArchiveApp*)context;
ArchiveApp* archive = context;
return scene_manager_handle_custom_event(archive->scene_manager, event);
}

bool archive_back_event_callback(void* context) {
static bool archive_back_event_callback(void* context) {
furi_assert(context);
ArchiveApp* archive = (ArchiveApp*)context;
ArchiveApp* archive = context;
return scene_manager_handle_back_event(archive->scene_manager);
}

ArchiveApp* archive_alloc() {
static void archive_tick_event_callback(void* context) {
furi_assert(context);
ArchiveApp* archive = context;
scene_manager_handle_tick_event(archive->scene_manager);
}

static ArchiveApp* archive_alloc() {
ArchiveApp* archive = malloc(sizeof(ArchiveApp));

archive->gui = furi_record_open(RECORD_GUI);
archive->text_input = text_input_alloc();
string_init(archive->fav_move_str);

archive->view_dispatcher = view_dispatcher_alloc();
archive->scene_manager = scene_manager_alloc(&archive_scene_handlers, archive);
archive->view_dispatcher = view_dispatcher_alloc();

view_dispatcher_enable_queue(archive->view_dispatcher);
view_dispatcher_attach_to_gui(
archive->view_dispatcher, archive->gui, ViewDispatcherTypeFullscreen);

view_dispatcher_set_event_callback_context(archive->view_dispatcher, archive);
view_dispatcher_set_custom_event_callback(
archive->view_dispatcher, archive_custom_event_callback);
view_dispatcher_set_navigation_event_callback(
archive->view_dispatcher, archive_back_event_callback);
archive->gui = furi_record_open(RECORD_GUI);

archive->browser = browser_alloc();
ViewDispatcher* view_dispatcher = archive->view_dispatcher;
view_dispatcher_enable_queue(view_dispatcher);
view_dispatcher_set_event_callback_context(view_dispatcher, archive);
view_dispatcher_set_custom_event_callback(view_dispatcher, archive_custom_event_callback);
view_dispatcher_set_navigation_event_callback(view_dispatcher, archive_back_event_callback);
view_dispatcher_set_tick_event_callback(view_dispatcher, archive_tick_event_callback, 100);

view_dispatcher_add_view(
archive->view_dispatcher, ArchiveViewBrowser, archive_browser_get_view(archive->browser));
archive->dialogs = furi_record_open(RECORD_DIALOGS);

archive->text_input = text_input_alloc();
view_dispatcher_add_view(
archive->view_dispatcher, ArchiveViewTextInput, text_input_get_view(archive->text_input));
view_dispatcher, ArchiveViewTextInput, text_input_get_view(archive->text_input));

archive->widget = widget_alloc();
view_dispatcher_add_view(
archive->view_dispatcher, ArchiveViewWidget, widget_get_view(archive->widget));

archive->view_stack = view_stack_alloc();
view_dispatcher_add_view(
view_dispatcher, ArchiveViewStack, view_stack_get_view(archive->view_stack));

archive->browser = browser_alloc();
view_dispatcher_add_view(
archive->view_dispatcher, ArchiveViewBrowser, archive_browser_get_view(archive->browser));

// Loading
archive->loading = loading_alloc();

return archive;
}

void archive_free(ArchiveApp* archive) {
furi_assert(archive);
ViewDispatcher* view_dispatcher = archive->view_dispatcher;

view_dispatcher_remove_view(archive->view_dispatcher, ArchiveViewBrowser);
view_dispatcher_remove_view(archive->view_dispatcher, ArchiveViewTextInput);
view_dispatcher_remove_view(archive->view_dispatcher, ArchiveViewWidget);
// Loading
loading_free(archive->loading);

view_dispatcher_remove_view(view_dispatcher, ArchiveViewTextInput);
text_input_free(archive->text_input);

view_dispatcher_remove_view(view_dispatcher, ArchiveViewWidget);
widget_free(archive->widget);

view_dispatcher_remove_view(view_dispatcher, ArchiveViewStack);
view_stack_free(archive->view_stack);

view_dispatcher_remove_view(view_dispatcher, ArchiveViewBrowser);

view_dispatcher_free(archive->view_dispatcher);
scene_manager_free(archive->scene_manager);

browser_free(archive->browser);
string_clear(archive->fav_move_str);

text_input_free(archive->text_input);
furi_record_close(RECORD_DIALOGS);
archive->dialogs = NULL;

furi_record_close(RECORD_GUI);
archive->gui = NULL;

free(archive);
}

void archive_show_loading_popup(ArchiveApp* context, bool show) {
TaskHandle_t timer_task = xTaskGetHandle(configTIMER_SERVICE_TASK_NAME);
ViewStack* view_stack = context->view_stack;
Loading* loading = context->loading;

if(show) {
// Raise timer priority so that animations can play
vTaskPrioritySet(timer_task, configMAX_PRIORITIES - 1);
view_stack_add_view(view_stack, loading_get_view(loading));
} else {
view_stack_remove_view(view_stack, loading_get_view(loading));
// Restore default timer priority
vTaskPrioritySet(timer_task, configTIMER_TASK_PRIORITY);
}
}

int32_t archive_app(void* p) {
UNUSED(p);

ArchiveApp* archive = archive_alloc();
view_dispatcher_attach_to_gui(
archive->view_dispatcher, archive->gui, ViewDispatcherTypeFullscreen);
scene_manager_next_scene(archive->scene_manager, ArchiveAppSceneBrowser);
view_dispatcher_run(archive->view_dispatcher);
archive_free(archive);

archive_free(archive);
return 0;
}
10 changes: 10 additions & 0 deletions applications/main/archive/archive_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
#include <gui/scene_manager.h>
#include <gui/modules/text_input.h>
#include <gui/modules/widget.h>
#include <gui/view_stack.h>
#include <dialogs/dialogs.h>
#include <gui/modules/loading.h>
#include <loader/loader.h>

#include "views/archive_browser_view.h"
Expand All @@ -18,17 +21,24 @@ typedef enum {
ArchiveViewTextInput,
ArchiveViewWidget,
ArchiveViewTotal,
ArchiveViewStack,
} ArchiveViewEnum;

struct ArchiveApp {
Gui* gui;
ViewDispatcher* view_dispatcher;
ViewStack* view_stack;
SceneManager* scene_manager;
ArchiveBrowserView* browser;
TextInput* text_input;
Widget* widget;
DialogsApp* dialogs;
Loading* loading;
FuriPubSubSubscription* loader_stop_subscription;

string_t fav_move_str;
char text_store[MAX_NAME_LEN];
char file_extension[MAX_EXT_LEN + 1];
};

void archive_show_loading_popup(ArchiveApp* context, bool show);
1 change: 1 addition & 0 deletions applications/main/archive/helpers/archive_browser.c
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ void archive_show_file_menu(ArchiveBrowserView* browser, bool show) {
if(archive_is_item_in_array(model, model->item_idx)) {
model->menu = true;
model->menu_idx = 0;
menu_array_reset(model->context_menu);
ArchiveFile_t* selected =
files_array_get(model->files, model->item_idx - model->array_offset);
selected->fav = archive_is_favorite("%s", string_get_cstr(selected->path));
Expand Down
35 changes: 35 additions & 0 deletions applications/main/archive/helpers/archive_files.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,38 @@ void archive_delete_file(void* context, const char* format, ...) {

string_clear(filename);
}

FS_Error archive_rename_file_or_dir(void* context, const char* src_path, const char* dst_path) {
furi_assert(context);

FURI_LOG_I(TAG, "Rename from %s to %s", src_path, dst_path);

ArchiveBrowserView* browser = context;
Storage* fs_api = furi_record_open(RECORD_STORAGE);

FileInfo fileinfo;
storage_common_stat(fs_api, src_path, &fileinfo);

FS_Error error = FSE_OK;

if(!path_contains_only_ascii(dst_path)) {
error = FSE_INVALID_NAME;
} else {
error = storage_common_rename(fs_api, src_path, dst_path);
}
furi_record_close(RECORD_STORAGE);

if(archive_is_favorite("%s", src_path)) {
archive_favorites_rename(src_path, dst_path);
}

if(error == FSE_OK || error == FSE_EXIST) {
FURI_LOG_I(TAG, "Rename from %s to %s is DONE", src_path, dst_path);
archive_refresh_dir(browser);
} else {
FURI_LOG_E(
TAG, "Rename failed: %s, Code: %d", filesystem_api_error_get_desc(error), error);
}

return error;
}
2 changes: 2 additions & 0 deletions applications/main/archive/helpers/archive_files.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <m-array.h>
#include <m-string.h>
#include <storage/storage.h>
#include "toolbox/path.h"

typedef enum {
ArchiveFileTypeIButton,
Expand Down Expand Up @@ -62,3 +63,4 @@ void archive_set_file_type(ArchiveFile_t* file, const char* path, bool is_folder
bool archive_get_items(void* context, const char* path);
void archive_file_append(const char* path, const char* format, ...);
void archive_delete_file(void* context, const char* format, ...);
FS_Error archive_rename_file_or_dir(void* context, const char* src_path, const char* dst_path);
52 changes: 52 additions & 0 deletions applications/main/archive/helpers/archive_menu.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
#pragma once

#include <m-array.h>
#include <m-string.h>

typedef struct {
string_t text;
uint32_t event;
} ArchiveContextMenuItem_t;

static void ArchiveContextMenuItem_t_init(ArchiveContextMenuItem_t* obj) {
string_init(obj->text);
obj->event = 0; // ArchiveBrowserEventFileMenuNone
}

static void ArchiveContextMenuItem_t_init_set(
ArchiveContextMenuItem_t* obj,
const ArchiveContextMenuItem_t* src) {
string_init_set(obj->text, src->text);
obj->event = src->event;
}

static void ArchiveContextMenuItem_t_set(
ArchiveContextMenuItem_t* obj,
const ArchiveContextMenuItem_t* src) {
string_init_set(obj->text, src->text);
obj->event = src->event;
}

static void ArchiveContextMenuItem_t_clear(ArchiveContextMenuItem_t* obj) {
string_clear(obj->text);
}

ARRAY_DEF(
menu_array,
ArchiveContextMenuItem_t,
(INIT(API_2(ArchiveContextMenuItem_t_init)),
SET(API_6(ArchiveContextMenuItem_t_set)),
INIT_SET(API_6(ArchiveContextMenuItem_t_init_set)),
CLEAR(API_2(ArchiveContextMenuItem_t_clear))))

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-function"
// Using in applications/archive/views/archive_browser_view.c
static void archive_menu_add_item(
ArchiveContextMenuItem_t* obj,
string_t text,
uint32_t event) {
string_init_move(obj->text, text);
obj->event = event;
}
#pragma GCC diagnostic pop
11 changes: 10 additions & 1 deletion applications/main/archive/scenes/archive_scene_browser.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,23 @@ bool archive_scene_browser_on_event(void* context, SceneManagerEvent event) {
case ArchiveBrowserEventFileMenuRename:
if(favorites) {
browser->callback(ArchiveBrowserEventEnterFavMove, browser->context);
} else if((archive_is_known_app(selected->type)) && (selected->is_app == false)) {
//} else if((archive_is_known_app(selected->type)) && (selected->is_app == false)) {
} else {
// Added ability to rename files and folders
archive_show_file_menu(browser, false);
scene_manager_set_scene_state(
archive->scene_manager, ArchiveAppSceneBrowser, SCENE_STATE_NEED_REFRESH);
scene_manager_next_scene(archive->scene_manager, ArchiveAppSceneRename);
}
consumed = true;
break;
case ArchiveBrowserEventFileMenuInfo:
archive_show_file_menu(browser, false);
scene_manager_set_scene_state(
archive->scene_manager, ArchiveAppSceneBrowser, SCENE_STATE_DEFAULT);
scene_manager_next_scene(archive->scene_manager, ArchiveAppSceneInfo);
consumed = true;
break;
case ArchiveBrowserEventFileMenuDelete:
if(archive_get_tab(browser) != ArchiveTabFavorites) {
scene_manager_next_scene(archive->scene_manager, ArchiveAppSceneDelete);
Expand Down
1 change: 1 addition & 0 deletions applications/main/archive/scenes/archive_scene_config.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
ADD_SCENE(archive, browser, Browser)
ADD_SCENE(archive, rename, Rename)
ADD_SCENE(archive, delete, Delete)
ADD_SCENE(archive, info, Info)
4 changes: 0 additions & 4 deletions applications/main/archive/scenes/archive_scene_delete.c
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
#include "../archive_i.h"
#include "../helpers/archive_favorites.h"
#include "../helpers/archive_files.h"
#include "../helpers/archive_apps.h"
#include "../helpers/archive_browser.h"
#include "toolbox/path.h"
#include "m-string.h"

#define SCENE_DELETE_CUSTOM_EVENT (0UL)
#define MAX_TEXT_INPUT_LEN 22
Expand Down
Loading

0 comments on commit 3a1705b

Please sign in to comment.