Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR Remote plugin improvements #535

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Conversation

friebel
Copy link

@friebel friebel commented Feb 19, 2023

What's new

  • Better align button text
  • Do not depend on config file ordering

Verification

  • Use a different key order in an IR Remote config file; I tested with
REMOTE: /ext/infrared/created/FlameLight.ir
OK: On
OKHOLD: Off
UP: BrightUp
DOWN: BrightDown
LEFT: LightMode
RIGHT: FlameMode
BACK: 
UPHOLD: 
DOWNHOLD: 
LEFTHOLD: 
RIGHTHOLD: BreathMode

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Move text right by 4 pixels to align it better to the center of the
screen.
Rewind to the start of the file before reading each key. This enables
using a custom key order in the config file.
@RogueMaster
Copy link
Owner

Thank you for the improvements...

@RogueMaster RogueMaster merged commit 91263ea into RogueMaster:420 Feb 20, 2023
@friebel friebel deleted the ir_remote branch February 20, 2023 10:56
RogueMaster pushed a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants