Skip to content

Commit

Permalink
validate-block: Fix TrieCache implementation (paritytech#2214)
Browse files Browse the repository at this point in the history
The trie cache implementation was ignoring the `storage_root` when
setting up the value cache. The problem with this is that the value
cache works using `storage_keys` and these keys are not unique across
different tries. A block can actually have different tries (main trie
and multiple child tries). This pull request fixes the issue by not
ignoring the `storage_root` and returning an unique `value_cache` per
`storage_root`. It also adds a test for the seen bug and improves
documentation that this doesn't happen again.
  • Loading branch information
bkchr authored and RomarQ committed Feb 8, 2024
1 parent 2fe3145 commit 2d158b1
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 2d158b1

Please sign in to comment.