Create Convert plugin #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 29, 2017 14:54
Converts different units of measurements as well as currencies.
I have added more code styling changes, however I have not tested the functionality of the plugin with Jeeves.
ekinhbayar
reviewed
Sep 28, 2017
src/Plugins/Convert.php
Outdated
| if (in_array($needle, $item)) { | ||
|
|
||
| return $key; | ||
|
|
There was a problem hiding this comment.
Remove newlines inside simple if statements <3
PeeHaa
reviewed
Sep 28, 2017
src/Plugins/Convert.php
Outdated
| $message | ||
| ); | ||
|
|
||
| } |
There was a problem hiding this comment.
It would be better if the body of the case is moved to a method. So you only have a method call in here.
PeeHaa
reviewed
Sep 28, 2017
src/Plugins/Convert.php
Outdated
| $toRate = $this->getRate($to, $xpath); | ||
|
|
||
| return (($amount / $fromRate) * ($toRate)); | ||
|
|
PeeHaa
reviewed
Sep 28, 2017
src/Plugins/Convert.php
Outdated
| ] | ||
| ]; | ||
|
|
||
|
|
DaveRandom
reviewed
Sep 29, 2017
| "try", | ||
| "turkish lira", | ||
| "turkish liras", | ||
| "turkish lire" |
There was a problem hiding this comment.
Should we also support tofurkish? Some users may be vegetarian.
Removed unnecessary newlines. Moved switch case to method getConvertedToAmount. Added additional check for Tofurkish in to or from unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts different units of measurements as well as currencies.