feat(Hooks): Expose useFloatingElement for positioning
#2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7kvqbe1
added
Type: Enhancement
m7kvqbe1
force-pushed
the
feat/refactor-sheet-tether-usage
branch
26 times, most recently
from
9b871d1
to
f803feb
Compare
m7kvqbe1
force-pushed
the
feat/refactor-sheet-tether-usage
branch
14 times, most recently
from
5c70d3f
to
73f5117
Compare
thyhjwb6
approved these changes
Jun 9, 2021
packages/react-component-library/src/primitives/FloatingBox/partials/StyledFloatingBox.tsx
Show resolved
Hide resolved
packages/react-component-library/src/components/DatePicker/DatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/react-component-library/src/components/Popover/Popover.tsx
Outdated
Show resolved
Hide resolved
packages/react-component-library/src/components/TopLevelNavigation/Sheet/Sheet.tsx
Outdated
Show resolved
Hide resolved
m7kvqbe1
force-pushed
the
feat/refactor-sheet-tether-usage
branch
from
b4ef74b
to
39e6c47
Compare
m7kvqbe1
force-pushed
the
feat/refactor-sheet-tether-usage
branch
from
39e6c47
to
f1eca0b
Compare
m7kvqbe1
force-pushed
the
feat/refactor-sheet-tether-usage
branch
from
f1eca0b
to
6fcf6b3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1642
Overview
FloatingBoxnow intelligently positions itself based on the available screen real-estate.Reason
Work carried out
useFloatingElementhookFloatingBoximplementation to consume hookPopoverusageDatePickerusageSheetusage (Masthead, SidebarE, Sidebar)Screenshot
Developer notes
I'm currently battling with some failing tests but feel free to cast an eye over the changes.Act warning in tests floating-ui/react-popper#368 & Popper causing warnings when running tests floating-ui/react-popper#350