-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ContextMenu): Intelligently position context menu #3119
feat(ContextMenu): Intelligently position context menu #3119
Conversation
fcfd026
to
0d10733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well from testing 👍
There's a build error in the smoke test fyi.
Also, I'm not sure about initialIsOpen
in all of these cases – some of them try to react to the prop changing as well I think (there's a useEffect
in useOpenClose
).
9accadb
to
95247e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have this question:
Also, I'm not sure about initialIsOpen in all of these cases – some of them try to react to the prop changing as well I think (there's a useEffect in useOpenClose).
Otherwise looks good 👍
95247e0
to
abfb7d3
Compare
Dropped the |
Kudos, SonarCloud Quality Gate passed! |
Related issue
Closes #2465
Overview
Intelligently position the
ContextMenu
based on the available screen real-estate.Link to preview
https://6214cbcefa42c7b48aad1817--optimistic-williams-bf676e.netlify.app
Reason
Work carried out
RenameuseHideShow
hookisOpen
param toinitialIsOpen
useClickMenu
hook and leverageuseFloatingElement