Add support for argon2id digest #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijh
force-pushed
the
feature/argon2id
branch
from
028ec78
to
ab729e5
Compare
|
bump |
|
Sorry, I have been very busy lately and have not had time to review these |
|
slow and steady wins the race |
|
bump 🤷♂️ |
|
Will review soon, sorry |
|
@elijh this looks good to me... mind rebasing your branch? |
Note: for libsodium >= 1.0.15, the default digest algorithm for argon2 changed from argon2i to argon2id. This means RbNaCl::PasswordHash.argon2() will produce different results depending on which libsodium you have installed. You should now use RbNaCl::PasswordHash.argon2i() or RbNaCl::PasswordHash.argon2id() instead. RbNaCl::PasswordHash.argon_str() is unaffected.
|
@tarcieri done, thanks 🎉 |
|
Thank you! Sorry it took so long! |
|
Will try to do another release relatively soon. There are a few changes in the works. It might be a good opportunity to also completely revamp the way how rbnacl-libsodium works. |
Merged
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 17, 2018
## [6.0.0] (2018-11-08) [6.0.0]: RubyCrypto/rbnacl#182 * [#180](RubyCrypto/rbnacl#180) Deprecate rbnacl-libsodium. ([@tarcieri]) * [#176](RubyCrypto/rbnacl#176) Add support for XChaCha20-Poly1305. ([@AnIrishDuck]) * [#174](RubyCrypto/rbnacl#174) Fix buffer size type in `randombytes_buf` binding. ([@elijh]) * [#172](RubyCrypto/rbnacl#172) Add support for argon2id digest. ([@trofi]) * [#166](RubyCrypto/rbnacl#166) Support for non-32-byte HMAC-SHA256/512 keys. ([@nsheremet])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for argon2id digest, if libsodium >= 1.0.13.
Note: for libsodium >= 1.0.15, the default digest algorithm for argon2
changed from argon2i to argon2id.
This means RbNaCl::PasswordHash.argon2() will produce different results
depending on which libsodium you have installed.
You should now use RbNaCl::PasswordHash.argon2i() or
RbNaCl::PasswordHash.argon2id() instead.
RbNaCl::PasswordHash.argon_str() is unaffected.