Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows vs2022 problems #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

escolano
Copy link

@escolano escolano commented Nov 8, 2022

No description provided.

-export fuctions DLLEXPORT and RL_JSON_EXTERN that become DLLEXPORT, DLLIMPORT, empty ... as needed, MODULE_SCOPE -> extern
-avoid C++ keywords as variable names: new -> new_obj, template -> template_obj, bool -> bool_obj
-castings: structs, (Tcl_Obj*), ckalloc
-define sowehow missing Windows functions: #define snprintf _snprintf , #define unlink _unlink, .. mkstemp and fdopen -> _mkstemp
-C90 unsupported intialization struct parse_error details = {};
-unsigned long addr -> Tcl_WideInt addr and Tcl_GetLongFromObj -> Tcl_GetWideIntFromObj
@escolano escolano closed this Nov 8, 2022
@escolano escolano reopened this Nov 8, 2022
@escolano
Copy link
Author

escolano commented Nov 8, 2022

I have been able to compile the package rl_json in Windows (x63 and x32) with Visual Studio 2022 (but other VS versions are also valid)
The modified source code is also checked that compile on Linux and macOs platforms.

I wanted to share this effort, to avoid be repeated for other users that want your package compiled for Windows
I expect this change to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant