-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panda Level: Added Shotgun gem and simple link to the /about page in the layout. #14
base: master
Are you sure you want to change the base?
Conversation
@jwo Tiger Level completed and deployed. |
get '/' do | ||
erb :dashboard | ||
end | ||
#get '/' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I don't like commented out code) -- just delete it, you can always get it back through git.
Great Panda submission, works great |
@jwo Corrections made. Thanks. |
'I like Purple.', | ||
'The next language I\'m learning is Python.' | ||
] | ||
@factoid = list.shuffle.sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not shuffle.sample). but sample
@jwo Oops. Done. |
@jwo I've managed to copy the Choose Your Own Adventure code into the project. Solving dependencies issues along the way. In terms of "let the user select their adventure and tell them if they died or not", I'm in two minds as to use GET or POST request. I'm leaning towards GETs as this seems like a click-based game. Any advice? |
I would use POST --- In general, GET should be non-destructive; that is, GETs have no side-affects. I should be able to gET GET GET and it'll be the same. POSTs, on the other hand, won't be run by search engines. They are manually executed. |
Code so far looks way excellent |
@jwo Deployed to http://infinite-island-4698.herokuapp.com/