Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panda Level: Added Shotgun gem and simple link to the /about page in the layout. #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

codeblahblah
Copy link

@codeblahblah
Copy link
Author

@jwo Tiger Level completed and deployed.

get '/' do
erb :dashboard
end
#get '/' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I don't like commented out code) -- just delete it, you can always get it back through git.

@jwo
Copy link
Member

jwo commented Feb 14, 2014

Great Panda submission, works great

@codeblahblah
Copy link
Author

@jwo Corrections made. Thanks.

'I like Purple.',
'The next language I\'m learning is Python.'
]
@factoid = list.shuffle.sample
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not shuffle.sample). but sample

@codeblahblah
Copy link
Author

@jwo Oops. Done.

@codeblahblah
Copy link
Author

@jwo I've managed to copy the Choose Your Own Adventure code into the project. Solving dependencies issues along the way. In terms of "let the user select their adventure and tell them if they died or not", I'm in two minds as to use GET or POST request. I'm leaning towards GETs as this seems like a click-based game. Any advice?

@jwo
Copy link
Member

jwo commented Feb 17, 2014

I would use POST --- In general, GET should be non-destructive; that is, GETs have no side-affects. I should be able to gET GET GET and it'll be the same.

POSTs, on the other hand, won't be run by search engines. They are manually executed.

@jwo
Copy link
Member

jwo commented Feb 17, 2014

Code so far looks way excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants