Adds method furlong to km #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,4 +4,8 @@ class Furlong | |||
| def miles_to_kilometers(miles) | |||
| miles * KM_PER_MILE | |||
| end | |||
|
|
|||
| def furlong_to_kilometers(furlong) | |||
| return furlong * 0.201168 | |||
There was a problem hiding this comment.
The 0.201168 looks like a "magic" number here. Instead, I'd like to see a constant "KM_PER_MILE"
Or, if you'd like to not do constants, you can still keep everything defined in the method:
def furlong_to_kilometers(furlong)
return furlong * furlong_per_mile=0.201168
end
furlong_to_kilometers 1
=> 0.0201Note I don't love this, but at least future-you can tell what 0.201168 means
There was a problem hiding this comment.
Working example for you: http://rubyfiddle.com/riddles/22ff9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Assignment. Used Rspec. Comments welcome.