Refactored Field Error Function #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahadMuhammad
force-pushed
the
Refactoring-Field-Error-Function
branch
2 times, most recently
from
032ebe8
to
cdd59b8
Compare
CohenArthur
approved these changes
Jun 28, 2023
MahadMuhammad
force-pushed
the
Refactoring-Field-Error-Function
branch
2 times, most recently
from
87a8284
to
60904c1
Compare
CohenArthur
approved these changes
Jun 29, 2023
|
@MahadMuhammad please fix the conflicts and I will merge this PR |
MahadMuhammad
force-pushed
the
Refactoring-Field-Error-Function
branch
2 times, most recently
from
cb120fd
to
60904c1
Compare
MahadMuhammad
force-pushed
the
Refactoring-Field-Error-Function
branch
2 times, most recently
from
60904c1
to
2ddf542
Compare
MahadMuhammad
force-pushed
the
Refactoring-Field-Error-Function
branch
4 times, most recently
from
2153944
to
634b286
Compare
Refactored field error function into one funciton Fixes Rust-GCC#2336 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (emit_invalid_field_error): Refactored Field Error Function (TypeCheckPattern::visit): called emit_invalid_field_error function Signed-off-by: Muhammad Mahad <[email protected]>
MahadMuhammad
force-pushed
the
Refactoring-Field-Error-Function
branch
from
634b286
to
41f5344
Compare
|
@CohenArthur Done. After 5 hours of fighting with git :D |
aw :) thanks for the work haha. next time if you want we can jump on a call and fix these together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored field error function into one function, To make easier error emission.
Fixes Refactoring Field Error Function into one Function #2336
Refactored Both function calls into function.
Called function at the error emission part.
gcc/rust/ChangeLog: