Non-allowed default type paramters #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * hir/rust-ast-lower-item.cc (ASTLoweringItem::visit): Added more helpful error message. gcc/testsuite/ChangeLog: * rust/compile/generics10.rs: for dejagnu. Signed-off-by: Muhammad Mahad <[email protected]>
CohenArthur
approved these changes
Aug 17, 2023
Comment on lines
+653
to
+661
| rich_location rich_locus (line_table, t.get_locus ()); | ||
| rich_locus.add_fixit_replace ( | ||
| t.get_locus (), "for more information, see issue #36887 " | ||
| "<https://github.com/rust-lang/rust/" | ||
| "issues/36887>"); | ||
| rust_error_at (rich_locus, | ||
| "defaults for type parameters are only " | ||
| "allowed in %<struct%>, %<enum%>, %<type%>, " | ||
| "or %<trait%> definitions"); |
There was a problem hiding this comment.
nice, it looks good! in a different PR, could you factor these lines in a separate function? this way we can modify the error message without changing it in two places
There was a problem hiding this comment.
@philberty left this issue to me to decide, whether to create a separate class for refactoring these errors.
But that seems excessive. What do you think, @CohenArthur? Should I create a separate class or add a refactor function when we encounter these cases?
There was a problem hiding this comment.
A separate class or a separate function is a good idea. I like both :)
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-allowed default
typeparamtersfixithint.gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: