Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visibility of sdl2::event::Event::from_ll to public #1210

Closed
jpteb opened this issue Feb 17, 2022 · 0 comments · Fixed by #1211
Closed

Change visibility of sdl2::event::Event::from_ll to public #1210

jpteb opened this issue Feb 17, 2022 · 0 comments · Fixed by #1211

Comments

@jpteb
Copy link
Contributor

jpteb commented Feb 17, 2022

As mentioned in #1023 I have a use case to convert a raw *mut sdl2_sys::SDL_Event into a sdl2::event::Event. Changing the visibility from sdl2::event::Event::from_ll to public would simplify this process greatly.

Other from_ll functions are already public and there doesn't seem to be a problem with changing others to public as well. It might even be worth thinking about setting all from_ll/to_ll functions to public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant