Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an ability to detect mouse events generated from touch events #1267

Closed
wants to merge 2 commits into from

Conversation

KivApple
Copy link

@KivApple KivApple commented Oct 22, 2022

Fix for #1265

@Cobrand
Copy link
Member

Cobrand commented Oct 25, 2022

I think it should be a method and not a variable inside the enum. This is something you can "generate" from the struct itself, so it's more appropriate to use a method is_touch(). Also, it's a breaking change since we would add a variable to quite a lot of variants, which I'm not really a fan of.

@KivApple
Copy link
Author

I see the problem in the fact that is_touch has some meaning only for few enum variants (obviously which are related to mouse events), but it will be defined for the whole enum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants