Fix cmake build failure when using multi-config generators #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By also setting `CMAKE_CONFIGURATION_TYPES` to the required config the build no longer fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with this library I notices an annoying problem.
When building the library with the
bundledfeature and having the CMAKE_GENERATOR environment variable set to a so called multi-config generator like Ninja Multi-Config the build for sdl2 fails.This patch fixes this annoyance by simply also settings the CMAKE_CONFIGURATION_TYPES for these builds since the normal CMAKE_BUILD_TYPE variable is ignored when using multi-config generators.
With that we essentially create a single-config build for our multi-config generator which builds without problems.