Added macos check to SDL_Metal_DestroyView call #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can skip the changelog for this one, as long at it's only visible in tools like perf no one will really care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a cfg check to
SDL_Metal_DestroyViewso that it works similar toSDL_Metal_CreateView. Without this change, tools likeperfcomplain about not finding the function:symbol lookup error: /home/somewhat/personal/info: undefined symbol: SDL_Metal_DestroyViewThis change has only been tested on linux
Also should I add this to the changelog or does this count as internal?