Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ub and shrink unsafe blocks #1435

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix ub and shrink unsafe blocks #1435

wants to merge 7 commits into from

Commits on Sep 20, 2024

  1. fix transmuting to invalid value

    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3894dbf View commit details
    Browse the repository at this point in the history

  2. fix public access to raw pointer

    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    595f8a8 View commit details
    Browse the repository at this point in the history

  3. add repr(transparent) to safely pointer-cast 

    between `FRect` and `sys::SDL_FRect`, and `FPoint` and`sys::SDL_FPoint`.
    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    df06202 View commit details
    Browse the repository at this point in the history

  4. add null pointer check before calling CStr::from_ptr 

    also shrink unsafe blocks
    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f642dd2 View commit details
    Browse the repository at this point in the history

  5. return pointer with mutable provenance from FRect::raw_mut 

    before this commit writing to the pointer returned by `FRect::raw_mut`
was undefined behavior.
    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    103d5bd View commit details
    Browse the repository at this point in the history

  6. fix use after free and unwind through FFI boundary in timer.rs

    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    10b888e View commit details
    Browse the repository at this point in the history

  7. update changelog

    @antonilol
    antonilol committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4203523 View commit details
    Browse the repository at this point in the history