Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making sure allocation failures are handled locally (i.e. don't forget to recover) #204

Closed
Ericson2314 opened this issue Apr 17, 2021 · 1 comment
Closed

Making sure allocation failures are handled locally (i.e. don't forget to recover) #204

Ericson2314 opened this issue Apr 17, 2021 · 1 comment
Labels
• lib Related to the `rust/` library.

Comments

@Ericson2314
Copy link

i have opened rust-lang/wg-allocators#87 and rust-lang/rust#84266 about this. Should be easy to pass the appropriate flags to rustc to disable that feature if the PR or something like it lands.
@ojeda ojeda added prio: high • lib Related to the `rust/` library. labels Apr 17, 2021
@ojeda
Copy link
Member

ojeda commented Apr 17, 2021

This should probably go into #199.

@ojeda ojeda closed this as completed Apr 19, 2021
@ojeda ojeda mentioned this issue Apr 19, 2021
Closed
ojeda pushed a commit that referenced this issue Jan 10, 2022
@nikunjad @bonzini
KVM: x86: Check for rmaps allocation
fffb532 
With TDP MMU being the default now, access to mmu_rmaps_stat debugfs
file causes following oops:

BUG: kernel NULL pointer dereference, address: 0000000000000000
PGD 0 P4D 0
Oops: 0000 [#1] PREEMPT SMP NOPTI
CPU: 7 PID: 3185 Comm: cat Not tainted 5.16.0-rc4+ #204
RIP: 0010:pte_list_count+0x6/0x40
 Call Trace:
  <TASK>
  ? kvm_mmu_rmaps_stat_show+0x15e/0x320
  seq_read_iter+0x126/0x4b0
  ? aa_file_perm+0x124/0x490
  seq_read+0xf5/0x140
  full_proxy_read+0x5c/0x80
  vfs_read+0x9f/0x1a0
  ksys_read+0x67/0xe0
  __x64_sys_read+0x19/0x20
  do_syscall_64+0x3b/0xc0
  entry_SYSCALL_64_after_hwframe+0x44/0xae
 RIP: 0033:0x7fca6fc13912

Return early when rmaps are not present.

Reported-by: Vasant Hegde <[email protected]>
Tested-by: Vasant Hegde <[email protected]>
Signed-off-by: Nikunj A Dadhania <[email protected]>
Reviewed-by: Peter Xu <[email protected]>
Reviewed-by: Sean Christopherson <[email protected]>
Message-Id: <[email protected]>
Cc: [email protected]
Fixes: 3bcd066 ("KVM: X86: Introduce mmu_rmaps_stat per-vm debugfs file")
Signed-off-by: Paolo Bonzini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
• lib Related to the `rust/` library.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ojeda @Ericson2314