PipeWire host #651
Draft
PipeWire host #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m00nwtchr
force-pushed
the
pipewire-host
branch
from
8e75170
to
aae2d78
Compare
There was a problem hiding this comment.
Some preliminary comments.
After digging a bit into pipewire-rs it seems that it still lacks a lot of proper binding for essential interfaces, including device enumeration. So I guess the backend will also be blocked on that.
I also look forward to making some MRs to pipewire-rs as a part of a different personal project, so hopefully this will be unblocked soon.
| @@ -33,6 +33,8 @@ nix = "0.23" | |||
| libc = "0.2.65" | |||
| parking_lot = "0.11" | |||
| jack = { version = "0.8", optional = true } | |||
| # pipewire = { version = "0.4", optional = true } | |||
| pipewire = { git = "https://gitlab.freedesktop.org/pipewire/pipewire-rs", optional = true } | |||
There was a problem hiding this comment.
It probably doesn't matter since a git dependency can't be included in a published crate anyway, but you should suffix it the URL with .git so GitLab doesn't complain about that.
…impl platform: Conditional impl_platform_host based on feature flags
m00nwtchr
force-pushed
the
pipewire-host
branch
2 times, most recently
from
5cba950
to
61aa078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.