Adopt windows version range >=0.54, <=0.57 #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows
is a "heavy" crate. Duplicatewindows
versions in a tree can add precious seconds to compile times (or even minutes by some Bevy user reports). On the Bevy side, we are trying to ensure thatwindows
is only compiled once. We also believe it is in the ecosystem's best interest (and in the interest of crate owners that consumewindows
) to align their versioning with the rest of ecosystem. Therefore, I would like to encourage crate owners to adopt the following approach towindows
crate usage:We've picked 0.54 as a baseline because breaking API changes were made to use Rust Results instead of HRESULT.
I have personally tested that cpal compiles with 0.54, 0.56 (0.55 does not exist), and 0.57.