Add MSRV #108
Add MSRV #108
Conversation
|
@mitchmindtree do you think there should be a minimum supported Rust version of this crate, and should this version be 1.20.0? If no, that's fine as well, it would just unlock further work. |
|
I'm not too concerned with keeping an MSRV while we are pre-1.0, but then again I don't have a clear path in mind towards what 1.0 should be just yet! I would still be happy to merge this if you would like - it might be useful for people to know that at the moment anything after 1.20 does work? One thing that does come to mind is that the const generic work seems to be slowly getting closer to stable and it would be nice to take advantage of them after they land - otherwise I can't think of any newer features off the top of my head that we will desperately want to take advantage of. What are your thoughts? Would a MSRV be useful to you? |
Cool!
Const generics are really awesome, I concur. I have some use cases for them in my projects but not in lewton specifically. What would you want to use them for in sample?
It would definitely be useful to me. I'd like to use sample in lewton, but I'm trying to keep the MSRV of lewton (1.20.0) on older levels, thus I'd prefer sample to update its MSRV on a slower pace. I'm not sure what pace I want to target in lewton, but it should be slow enough for users to be able to adopt rustc updates before they use / contribute to lewton. I'm toying with a "whatever Firefox ESR uses" based schedule because even stable distros which usually don't upgrade any packages (like debian stable) will upgrade rustc to the version that Firefox ESR uses. That would mean delays of 2-14 months since the specific Rust version release. |
|
Thanks, I think lewton will use its own traits for now, similar to how claxon is doing it. |
This is the minimum version of Rust that this crate
seems to compile with. Let's test for it in travis.