Minor post-transfer changes

[newpavlov]

Not sure about the minimum supported Rust version for CI, for now it's 1.27.

[dignifiedquire]

LGTM, thanks

[newpavlov]

If you would like to continue being the main maintainer (and developer) of this crate, then I think the one to merge PRs (including this one) should be you. What do you think?

[dignifiedquire]

If you would like to continue being the main maintainer (and developer) of this crate, then I think the one to merge PRs (including this one) should be you. What do you think?

Makes sense, will merge once CI is happy and publish an initial version to crates.io later today

[newpavlov]

key::tests::key_generation_128 has failed with "unwrap() on None". I've restarted the test and it got "fixed". IIUC you have non-determinism in your tests and implementation has a bug.

Ideally we should be able to use deterministic RNG source for tests and OS RNG for everything else, but unfortunately it's not that easy right now.

[newpavlov]

BTW it would be nice to also add fuzzing testing, see cargo-fuzz.

[dignifiedquire]

key::tests::key_generation_128 has failed with "unwrap() on None". I've restarted the test and it got "fixed". IIUC you have non-determinism in your tests and implementation has a bug.

Argh :/ I saw this once before in a project that uses this, but didn't realize it comes from here.

Created an issue #2

BTW it would be nice to also add fuzzing testing, see cargo-fuzz.

Yes, definitely need this #3